flutter-intellij icon indicating copy to clipboard operation
flutter-intellij copied to clipboard

Remove unused await code

Open drown0315 opened this issue 1 year ago • 3 comments

Remove some unused await code

before:

  Future<int> _stopDaemon() async {
    if (Platform.isWindows) {
      return await exec('.\\third_party\\gradlew.bat', ['--stop']);
    } else {
      return await exec('./third_party/gradlew', ['--stop']);
    }
  }

after:

  Future<int> _stopDaemon() {
    if (Platform.isWindows) {
      return exec('.\\third_party\\gradlew.bat', ['--stop']);
    } else {
      return exec('./third_party/gradlew', ['--stop']);
    }
  }

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read the Flutter Style Guide recently, and have followed its advice.
  • [x] I signed the CLA.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

drown0315 avatar Jun 28 '24 13:06 drown0315

(triage) @drown0315 github is complaining that your commit is not signed and that's why merging it is blocked. Could you take a look and fix that? See also https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

goderbauer avatar Sep 03 '24 22:09 goderbauer

Thank for reply, I'll take care of that later.

drown0315 avatar Sep 05 '24 02:09 drown0315

(triage) @drown0315 github is complaining that your commit is not signed and that's why merging it is blocked. Could you take a look and fix that? See also https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

It's ok!

drown0315 avatar Sep 06 '24 13:09 drown0315

(triage) looks like there is some conflict. Hi @drown0315, can you resolve the merge conflict?

chunhtai avatar Nov 12 '24 23:11 chunhtai