flutter-intellij icon indicating copy to clipboard operation
flutter-intellij copied to clipboard

Remove the Flutter outline

Open kenzieschmoll opened this issue 1 year ago • 8 comments

The IntelliJ Structure view provides this functionality so we do not need to maintain our own.

kenzieschmoll avatar May 02 '24 16:05 kenzieschmoll

The main difference I see after looking at a few files is having some "wrap with..." buttons here: Image

I don't see this functionality available elsewhere, but are we okay with not having this any more?

CC @jwren

helin24 avatar May 09 '24 21:05 helin24

Yes, this issue was opened when we thought there was no difference in functionality between the Structure view and the Flutter Outline. I suspect that with time functionality like this might come from DevTools and DTD, but for the time being, we should not remove it.

jwren avatar May 09 '24 22:05 jwren

Okay, thanks for clarifying. For future reference, another thing that I found that is part of the flutter outline is this inline editing panel: https://github.com/flutter/flutter-intellij/pull/4160

helin24 avatar May 09 '24 22:05 helin24

I don't see this functionality available elsewhere, but are we okay with not having this any more?

These functions are all available as quick fixes, so I don't think the actions at the top should be a blocker to remove.

Screenshot 2024-05-09 at 3 27 03 PM

kenzieschmoll avatar May 09 '24 22:05 kenzieschmoll

Also, the outline view doesn't seem to load for me. We should add analytics to this view to see if many users are using it: Screenshot 2024-05-09 at 3 31 11 PM

kenzieschmoll avatar May 09 '24 22:05 kenzieschmoll

Also, the outline view doesn't seem to load for me

Ah, looks like this view is configured to only be enabled when there is a running app, which is a bug. The outline view + Hot UI for that matter should work with now connected app.

kenzieschmoll avatar May 09 '24 22:05 kenzieschmoll

We do have data on the usage of the outline, last week numbers below:

  • 1,000 unique users
  • 8,200 usages of jump to source from the preview
  • 2,000 usages of any of the shortcut actions
  • 3,500 users who have "enabled hot UI" in settings, which allows them to access the inline editing panel. I don't know how many are actually using the panel.

I didn't realize we could open the quick fix menu from the editor - knowing that makes me less reluctant to remove the outline view.

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

helin24 avatar May 10 '24 16:05 helin24

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

Once I killed the app I was running, I still had access to the Flutter Outline view. So maybe it only works after running an app at least once?

kenzieschmoll avatar May 10 '24 17:05 kenzieschmoll

We're going to close this for now since we want the outline buttons for discoverability

helin24 avatar May 21 '24 21:05 helin24