flutter-intellij icon indicating copy to clipboard operation
flutter-intellij copied to clipboard

Track down all manual calls to dispose() in the IntelliJ Plugin

Open jacob314 opened this issue 3 years ago • 1 comments

Some classes like FlutterWidgetPerf implement the Disposable interface but have dispose() called manually which is counter to how dispose() should be called for a properly functioning IntelliJ plugin.

Mixing manual and automatic calls to dispose leads to confusing bugs like https://github.com/flutter/flutter-intellij/issues/6042

jacob314 avatar Apr 02 '22 01:04 jacob314

FlutterWidgetPerf.dispose() is called by FlutterWidgetPerfManager.dispose(), which is itself never called due to using the project as a dispose parent: Disposer.register(project, this);

We need to fix #6076 before working on this one.

stevemessick avatar Apr 15 '22 19:04 stevemessick