engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[Android] Drops semantics query when app is not attached

Open chunhtai opened this issue 1 year ago • 4 comments

Is seems automatic test may send a11y query before the engine is attached. Add a guard to guard against it.

Pre-launch Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I signed the CLA.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai avatar Apr 10 '24 23:04 chunhtai

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Apr 10 '24 23:04 flutter-dashboard[bot]

@chunhtai I am going through my pr requests and found this. I believe you are not waiting on me if that is the case let me know.

reidbaker avatar Apr 22 '24 17:04 reidbaker

no, I have some other ideas to test this code. I will let you know once this pr is ready

chunhtai avatar Apr 22 '24 18:04 chunhtai

follow up to see if this is ready for review.

reidbaker avatar Jun 24 '24 17:06 reidbaker

Follow up again on this pr, can we close it if it is still not ready for review?

reidbaker avatar Aug 13 '24 14:08 reidbaker

I have time know, will ready this pr within this week

chunhtai avatar Aug 13 '24 21:08 chunhtai