engine icon indicating copy to clipboard operation
engine copied to clipboard

Small improvements to et lint command

Open johnmccutchan opened this issue 1 year ago • 1 comments

  • Default to dumping out lint logs (can be disabled with --quiet flag).
  • Add Logger.fatal which logs an error and throws a FatalError which is caught in main.
  • Simplify findDartBinDirectory implementation.
  • Make JSON serialized process artifacts more human readable.

johnmccutchan avatar Mar 13 '24 07:03 johnmccutchan

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 13 '24 07:03 flutter-dashboard[bot]

lgtm modulo test failures. I think it's possible to write unit tests of some of this as well, like the fatal() log message, at least.

added test here.

johnmccutchan avatar Mar 13 '24 20:03 johnmccutchan