engine icon indicating copy to clipboard operation
engine copied to clipboard

[Impeller] added missing golden test for DrawScaledTextWithPerspectiveSaveLayer

Open gaaclarke opened this issue 1 year ago • 1 comments

related:

  • https://github.com/flutter/flutter/issues/130633
  • https://github.com/flutter/engine/pull/51343

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke avatar Mar 12 '24 22:03 gaaclarke

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51368 at sha cf1907b2d339ebfc3dd9e5400cd2f94879a0f44f

flutter-dashboard[bot] avatar Mar 12 '24 23:03 flutter-dashboard[bot]