engine icon indicating copy to clipboard operation
engine copied to clipboard

[Fuchsia] Enable sound null safety everywhere

Open zijiehe-google-com opened this issue 1 year ago • 1 comments

This change enables null_safety on fuchsia everywhere and remove the legacy conditions.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

zijiehe-google-com avatar Mar 12 '24 17:03 zijiehe-google-com

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 13 '24 02:03 flutter-dashboard[bot]

Thank you Alexander and Siva. I addressed all the comments and added autosubmit label since the tree is closing now. Let me know if you have other comments.

zijiehe-google-com avatar Mar 13 '24 17:03 zijiehe-google-com