engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[web] Multi-view support for Skwasm

Open mdebbar opened this issue 2 years ago • 5 comments

Support multi-view mode in the Skwasm renderer.

Fixes https://github.com/flutter/flutter/issues/138925

mdebbar avatar Dec 11 '23 21:12 mdebbar

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Feb 01 '24 21:02 flutter-dashboard[bot]

@mdebbar is this ready for review and I've been blocking it for a while now?

ditman avatar Feb 24 '24 02:02 ditman

@mdebbar is this ready for review and I've been blocking it for a while now?

Nah, I'm self-blocked lol. I want to write tests before I submit this PR. (don't mind the merge commits being pushed, I'm just resolving merge conflicts with main).

mdebbar avatar Feb 26 '24 15:02 mdebbar

Can we make this a Draft PR for now then?

ditman avatar Feb 26 '24 21:02 ditman

(triage) I spoke to @mdebbar last week and they said this is still on their radar.

goderbauer avatar May 07 '24 22:05 goderbauer

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #48893 at sha 25cecbeb2f107c544677fbcb423fe0c3d69fcde1

flutter-dashboard[bot] avatar Aug 15 '24 17:08 flutter-dashboard[bot]

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #48893 at sha f5ddef35d4054edab268954e13a54069601a8012

flutter-dashboard[bot] avatar Aug 23 '24 14:08 flutter-dashboard[bot]