engine icon indicating copy to clipboard operation
engine copied to clipboard

[Display List] Add runtime color source dl unittest entry

Open flar opened this issue 3 years ago • 2 comments

Double checking that this should fail on Windows, but a simple follow-on fix will get it working again.

flar avatar Aug 19 '22 20:08 flar

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Aug 19 '22 20:08 flutter-dashboard[bot]

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar Sep 11 '22 18:09 flutter-dashboard[bot]

Revisiting this - first to rebase to ToT to resolve conflicts and verify that it still has an issue on Windows...

flar avatar Dec 07 '22 00:12 flar

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

flutter-dashboard[bot] avatar Mar 30 '23 20:03 flutter-dashboard[bot]

Closing this as stale.

chinmaygarde avatar Apr 06 '23 20:04 chinmaygarde