devtools icon indicating copy to clipboard operation
devtools copied to clipboard

Published 20 hours ago • verified publisher icon flutter

Rebuild Indicator UI support

Open jacob314 opened this issue 3 years ago • 1 comments

This adds rebuild indicator support which is disabled behind a flag until at least Flutter support for a couple new features needed for rebuild indicators is added. There is a stager offline sample demonstrating rebuilds from a modified version of Flutter. I've also deleted the CPU profiler window at the bottom of the performance page as it made performance painful as well as being confusing if you weren't on the timeline events tab as that was the only tab synced with it. Rebuild indicators are only available in debug mode currently but supporting in profile mode is possible.

I noticed a bug in the logic to track whether the performance page was currently processing so I also tossed in a fix for that on this CL. See FutureWorkTracker which avoids edge cases not handled in the previous performance controller impl.

Rebuilds are shown in two places in the performance page: Screen Shot 2022-09-30 at 3 42 20 PM Screen Shot 2022-09-30 at 3 41 10 PM

jacob314 avatar Sep 30 '22 23:09 jacob314

What is the "Overall" column of the Rebuild Stats tab showing? Are those counts since the last reload or app start?

InMatrix avatar Oct 05 '22 00:10 InMatrix

PTAL

jacob314 avatar Oct 19 '22 23:10 jacob314

Breaking out a couple pieces of this PR in https://github.com/flutter/devtools/pull/4629 so that I can build on top of them (since jacob is OOO for a few weeks). So FYI Jacob you'll want to merge master once that lands.

kenzieschmoll avatar Oct 20 '22 21:10 kenzieschmoll

PTAL

jacob314 avatar Nov 12 '22 00:11 jacob314