devtools icon indicating copy to clipboard operation
devtools copied to clipboard

UX improvement to banner warnings and errors

Open kenzieschmoll opened this issue 3 years ago • 6 comments

This changes the message on the performance page and cpu profiler page from an "error" to a "warning", and it tweaks the wording of this message. This PR also changes the message style a little bit by using an error/warning icon instead of the words "ERROR" and "WARNING". Screen Shot 2021-12-13 at 3 56 39 PM (note: this error screenshot is just to show the styling, and the text here is actually shown as a warning - not an error) Screen Shot 2021-12-13 at 4 04 44 PM

@InMatrix @cobblest

kenzieschmoll avatar Dec 14 '21 00:12 kenzieschmoll

Thanks for turning this into a PR. At the moment, there is a bit of a gap between what we tell users what they can do in debug mode and what they would find easy to do. In addition to UI improvements we might make to the perf page, I'm hoping to turn each task mentioned in the warning message (e.g., "building widgets") into a link to a how-to guide.

InMatrix avatar Dec 15 '21 06:12 InMatrix

I'm hoping to turn each task mentioned in the warning message (e.g., "building widgets") into a link to a how-to guide.

We may be able to do this fairly soon. I know @johnpryan has been looking into writing some documentation for these features.

kenzieschmoll avatar Dec 15 '21 18:12 kenzieschmoll

We will hold off on landing this PR until we have more actionable information we can point users to (flutter.dev documentation, debugging guides, etc.).

kenzieschmoll avatar Feb 16 '22 00:02 kenzieschmoll

Is there an issue # for creating those docs?

Hixie avatar Apr 26 '22 23:04 Hixie

@InMatrix are you opposed to landing this?

kenzieschmoll avatar Jul 12 '22 23:07 kenzieschmoll

I have no problem with merging this change.

InMatrix avatar Jul 15 '22 21:07 InMatrix