Joe Schoonover
Joe Schoonover
> I'll try to convert this to an extension. I'll do it in a single commit so that it's easily revertible. How does that sound @fluidnumerics-joe? Sounds good.
> @fluidnumerics-joe can you confirm that all works OK for you now with the extension? The only thing that I couldn't manage to do is to export the alias `ROCmGPU`....
Here's where we're at. I've made the following modifications to `baroclinic_adjustment.jl` ``` using Oceananigans, AMDGPU ``` and the grid construction now specifies GPU architecture with `GPU(AMDGPU.ROCBackend())`, ie, ``` grid =...
> Seems that we need to add methods for planning FFTs. I'll take a crack at this with an extension for Solvers.
I've gotten the transforms taken care of, but now the baroclinic_adjustment example fails with ``` $ julia --project=. baroclinic_adjustment.jl ERROR: LoadError: Scalar indexing is disallowed. Invocation of getindex resulted in...
Commented out the first plot of the buoyancy and was able to get past this. However, there's a correctness bug it seems.. It works fine with the CPU backend. I'll...
I'm game to try. Should we modify the baroclinic adjustment problem or is there another benchmark you have in mind?
`SplitExplicitFreeSurface` works well here. For reference, the script I'm using is here : https://github.com/FluidNumerics/oceananigans-on-amd-gpus/blob/main/benchmarks/baroclinic_adjustment/baroclinic_adjustment.jl I'll get profiling results posted soon.
Just want to confirm some final steps with @navidcy and @glwagner here to wrap up this PR. At the moment, I believe we just need to put in a method...
> I think we need to have an AMD-enabled CI? Is this something that is handled on the MIT side ? Only way I can help is through system procurement...