fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Fixing bug in flb_plugin.c: key -> value

Open QtRoS opened this issue 1 year ago • 3 comments

Sorry, there is nothing to fill there, it's obvious bug. Not sure about the fix though, just used exactly the same syntax as in the very next function flb_plugin_load_config_file


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

QtRoS avatar Nov 28 '24 17:11 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini please take a quick look on this one-line fix.

QtRoS avatar Dec 07 '24 10:12 QtRoS

@edsiper please take a look

QtRoS avatar Dec 18 '24 14:12 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini plugin loading from file is still broken, please take a look at this fix

QtRoS avatar Dec 26 '24 12:12 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini this one-liner fixes plugin loading (which are specified via config file, while via command line works ok), it's kinda important IMO, please take a look

QtRoS avatar Jan 09 '25 15:01 QtRoS

+1 I can't load plugin specified in plugins.conf

ssetin avatar Jan 10 '25 06:01 ssetin

@edsiper @leonardo-albertovich @fujimotos @koleini may I kindly ask you to review this one line fix of a typo?

QtRoS avatar Jan 21 '25 14:01 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini please take a look 🙏 I can't update FB to newest version because of this tiny bug...

QtRoS avatar Feb 26 '25 14:02 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini ping

QtRoS avatar Mar 12 '25 10:03 QtRoS

@edsiper @leonardo-albertovich @fujimotos @koleini ping-ping

QtRoS avatar Apr 09 '25 12:04 QtRoS

Seems that's fixed in other way

QtRoS avatar Jun 30 '25 18:06 QtRoS