pscript icon indicating copy to clipboard operation
pscript copied to clipboard

FAILED pscript/tests/test_parser2.py::TestFunctions::test_async_and_await

Open andreas-schwab opened this issue 1 year ago • 1 comments

=================================== FAILURES =================================== ______________________ TestFunctions.test_async_and_await ______________________

self = <test_parser2.TestFunctions object at 0x7f2d4a4f2e10>

def test_async_and_await(self):
    if sys.version_info < (3, 6):
        return

    foo = py2js('async def foo(): return 42\n\n')
    spam = py2js('async def spam(): print(await foo())\n\n')
    eggs = py2js('async def eggs(): return await foo()\n\n')
    js = foo + spam + eggs

    assert 'Promise' in evaljs(js + 'foo()')
    assert 'Promise' in evaljs(js + 'spam()')
    assert 'Promise' in evaljs(js + 'eggs()')

    assert '42' in evaljs(js + 'spam()')
  assert '42' not in evaljs(js + 'eggs()')

E AssertionError: assert '42' not in 'Promise { 42 }' E
E '42' is contained here: E Promise { 42 } E ? ++

pscript/tests/test_parser2.py:874: AssertionError =========================== short test summary info ============================ FAILED pscript/tests/test_parser2.py::TestFunctions::test_async_and_await - A... ============= 1 failed, 223 passed, 2 skipped in 670.27s (0:11:10) =============

According to https://github.com/nodejs/node/issues/56144 this is a bug in the test.

andreas-schwab avatar Dec 05 '24 16:12 andreas-schwab

I think we should just remove the eggs-part of the test, since it no longer shows what the test is trying to show (that the promise is pending).

almarklein avatar Dec 06 '24 08:12 almarklein