npm-module-boilerplate icon indicating copy to clipboard operation
npm-module-boilerplate copied to clipboard

Shouldn't the per-project config file (/path/to/my/project/.npmrc) be in the .gitignore file

Open cquezel opened this issue 6 years ago • 3 comments

Shouldn't the per-project config file (/path/to/my/project/.npmrc) be in the .gitignore file?

Ref: https://docs.npmjs.com/files/npmrc.html

cquezel avatar Jan 10 '19 21:01 cquezel

@cquezel But we don't have .npmrc in our project. If you think it's important, would you like to create a PR on why we need that and add the file and it's entry in .gitignore?

flexdinesh avatar Jan 11 '19 03:01 flexdinesh

I thought this was a "general" project for starting a npm module. The .npmrc file is a user per project configuration file used by npm. I think that most users would not want their personal configuration to be checked in to GIT or to use someone else's configuration which was accidentally checked in.

cquezel avatar Jan 28 '19 14:01 cquezel

You're right. I agree that this project should hightlight the use of .npmrc file. Feel free to create a PR or I can get to it in the next few days.

flexdinesh avatar Jan 28 '19 14:01 flexdinesh