scripts icon indicating copy to clipboard operation
scripts copied to clipboard

changelog: disable DHCP RapidCommit for CloudSigma OEM

Open daMupfel opened this issue 1 year ago • 7 comments

Disable DHCP RapidCommit for CLoudSigma OEM

This is related to the following issue: https://github.com/flatcar/Flatcar/issues/1438

How to use

Build OEM beta image and upload it to CloudSigma. Create a host with said image.

Testing done

I tested this by manually applying the OEM config to the /oem/cloud-config.yml file and rebooting.

Note: This is my idea how to fix this issue, i am unsure if this is the desired solution and if this is the right branch to merge into as it currently only is an issue on beta builds.

daMupfel avatar May 31 '24 14:05 daMupfel

Nice work, just what I needed.. :+1:

dosomder avatar Jun 18 '24 12:06 dosomder

Thanks for checking in to this, i will try to build it locally. Have never done it so we will see how it goes :).

daMupfel avatar Jun 19 '24 06:06 daMupfel

So i was finally able to test this.

While it does work, it only works after a reboot since the network configuration is already loaded at that point.

I was not able to figure out how to restart the network service. I tried:

runcmd:
  - sudo systemctl restart systemd-networkd

But found out later that runcmd is not supported by the coreos-cloudinit implementation.

Do you have a suggestion on how i could do that?

Regards,

David

daMupfel avatar Jun 27 '24 07:06 daMupfel

By the way, what is the plan of moving the next beta to stable? Since it would break for us at that point :)

daMupfel avatar Jun 28 '24 13:06 daMupfel

Okay, so after a bit of looking around in the coreos-cloud i found out that one can also provide network units to cores.units, this doesn't seem to be documented super well.

I built a custom image based on the latest beta and applied this change. This does now seem to work as intended.

Not sure if i require runtime: True i don't think it matters as it will write the file on every boot anyway?

Regards,

David

daMupfel avatar Jun 28 '24 14:06 daMupfel

@ader1990 Hi :),

Thank You for the initial review! Is there anything else i can provide to help this PR?

daMupfel avatar Jul 10 '24 13:07 daMupfel

This seems to have missed the stable now. I would like to ask again what there is we can provide to integrate this. We currently require an own image which we would like to stop again.

daMupfel avatar Aug 08 '24 15:08 daMupfel

This seems to have missed the stable now. I would like to ask again what there is we can provide to integrate this. We currently require an own image which we would like to stop again.

Hello @daMupfel sorry for the delay on this PR and thanks for pinging us again. It looks good to me:

  1. Do you want me to build an image for you to test with a built image?
  2. I think we can backport this to alpha and beta first before stable

tormath1 avatar Sep 02 '24 15:09 tormath1

@tormath1 Hi :), no worries. Just wanted to know where we stand here :).

Thank you very much for looking into this.

I think I adapted the PR as you requested.

Regarding the built. I was able to do so by following the documentation (with the container and then the main build and than the specific built). I can test it again if you want. The last time i applied it on the last beta image (which was promoted to stable).

Regards,

David

daMupfel avatar Sep 04 '24 13:09 daMupfel

@daMupfel I was about to merge this change but I just noticed that there is only one commit that contains the two changes (the actual change and the changelog entry) - you can split this change into two commits, e.g:

  • changelog: add entry
  • disable DHCP rapidcommit for cloud sigma

or just amend the commit to something like disable DHCP rapidcommit for cloud sigma

tormath1 avatar Sep 05 '24 14:09 tormath1

Hi @tormath1, i split it now up into two commits :).

daMupfel avatar Sep 10 '24 05:09 daMupfel

cherry-picked to:

  • flatcar-4081 (current alpha)
  • flatcar-4054 (current beta)

Thanks for your change!

By the way, I noticed there is no documentation for CloudSigma - is there any specific things to know to use Flatcar on this platform?

tormath1 avatar Sep 10 '24 07:09 tormath1

@tormath1 Thank you very much for taking care of my PR!

We don't have any affiliation other than being customers of CloudSigma. At some point, CloudSigma made an effort to support CoreOS, which is where this comes from. At that time, one could select CoreOS as a base image for new VMs. CoreOS then disappeared at some point from the UI. What we do nowadays is convert the OEM image to a raw image and then upload it as a custom base image to CloudSigma.

Please take this with a grain of salt since I am only an external observer.

daMupfel avatar Sep 10 '24 08:09 daMupfel