mev-boost
mev-boost copied to clipboard
flashbots
Min bid
π Summary
Allow users to set a minimum bid to accept a block from a relay
β± Motivation and Context
https://github.com/flashbots/mev-boost/issues/273
β I have run these commands
- [β
]
make lint - [β
]
make test-race - [β
]
go mod tidy
Codecov Report
Merging #274 (f10d25c) into main (5c49007) will decrease coverage by
15.46%. The diff coverage is54.76%.
@@ Coverage Diff @@
## main #274 +/- ##
===========================================
- Coverage 82.12% 66.66% -15.47%
===========================================
Files 5 7 +2
Lines 677 879 +202
===========================================
+ Hits 556 586 +30
- Misses 92 261 +169
- Partials 29 32 +3
| Flag | Coverage Ξ | |
|---|---|---|
| unittests | 66.66% <54.76%> (-15.47%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Ξ | |
|---|---|---|
| cli/main.go | 13.51% <45.71%> (ΓΈ) |
|
| server/service.go | 79.56% <100.00%> (-0.59%) |
:arrow_down: |
| cli/types.go | 0.00% <0.00%> (ΓΈ) |
|
| server/utils.go | 75.67% <0.00%> (+2.14%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
looks like a good feature to have. left a few comments, also please rebase π
@allboxes, I think this PR is step in the right direction given that many people are wary of running mev-boost especially since the mev-boost reward has the possibility of being less than the reward you would have earned from a locally produced block. I have 2 comments (although this may be beyond the scope of the PR)
-
There are 2 types of min bid, absolute min bid and relative min bid. I take it this PR is an absolute mid bid, but it would also be useful to have the option to specify a relative min bid which would be the min bid above the reward you would receive from a locally produced block
-
Is there a way of transmitting this information to the relay? Under this implementation if I have a min bid of .1 eth will the relay realize this and only submit bids of .1 eth or more? Will the bid immediately be rejected, giving the relay the opportunity to submit a higher bid? Or will the low bid be silently ignored? The last case seems sub-optimal if the relay is willing to bid higher but did not know of the min required bid of the validator.
Hey @jumboshrimp100 I appreciate the questions!
- There are 2 types of min bid, absolute min bid and relative min bid. I take it this PR is an absolute mid bid, but it would also be useful to have the option to specify a relative min bid which would be the min bid above the reward you would receive from a locally produced block
That's an interesting idea, but not in scope for mev-boost. Later, when the execution API adds the engine_getPayload endpoint (see this issue on GitHub), it will be possible for the validator client to compare the remote block's value to the local block's value. After this point, it's up the client to implement the feature (relative mid-bid) you mentioned.
- Is there a way of transmitting this information to the relay? Under this implementation if I have a min bid of .1 eth will the relay realize this and only submit bids of .1 eth or more? Will the bid immediately be rejected, giving the relay the opportunity to submit a higher bid? Or will the low bid be silently ignored? The last case seems sub-optimal if the relay is willing to bid higher but did not know of the min required bid of the validator.
Personally, if I were to use this I'd like to keep my min-bid preference private. And this doesn't really align with how things work. A relay only has one opportunity to send a bid to mev-boost. If mev-boost rejects that bid, there is no higher bid that the relay can send, it's already sent it's highest value bid.
