mev-boost-relay icon indicating copy to clipboard operation
mev-boost-relay copied to clipboard

optimistic v2 slowpath

Open michaelneuder opened this issue 2 years ago • 1 comments
trafficstars

📝 Summary

Completion of the v2 code. This is diffed off https://github.com/flashbots/mev-boost-relay/pull/524 to make the review clearer.

This follows up on the series: https://github.com/flashbots/mev-boost-relay/pull/479, https://github.com/flashbots/mev-boost-relay/pull/491, https://github.com/flashbots/mev-boost-relay/pull/494, https://github.com/flashbots/mev-boost-relay/pull/498, https://github.com/flashbots/mev-boost-relay/pull/513, https://github.com/flashbots/mev-boost-relay/pull/514, https://github.com/flashbots/mev-boost-relay/pull/518, https://github.com/flashbots/mev-boost-relay/pull/524 which aim at reducing the diff and productionizing https://github.com/flashbots/mev-boost-relay/pull/466.

⛱ Motivation and Context

This PR implements the slow path of the v2 code, which parses the full transactions and withdrawals, saves the payload, and runs the simulation.

📚 References

https://notes.ethereum.org/@mikeneuder/optimistic-v2

https://github.com/michaelneuder/optimistic-relay-documentation/blob/main/towards-epbs.md#optimistic-relay-v2-header-only-parsing


✅ I have run these commands

  • [x] make lint
  • [x] make test-race
  • [x] go mod tidy
  • [x] I have seen and agree to CONTRIBUTING.md

michaelneuder avatar Sep 15 '23 16:09 michaelneuder

Codecov Report

Merging #530 (1990182) into mikeneuder-2023-09-08-01 (335bff2) will increase coverage by 0.42%. The diff coverage is 68.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                     Coverage Diff                      @@
##           mikeneuder-2023-09-08-01     #530      +/-   ##
============================================================
+ Coverage                     35.64%   36.07%   +0.42%     
============================================================
  Files                            24       24              
  Lines                          5387     5467      +80     
============================================================
+ Hits                           1920     1972      +52     
- Misses                         3243     3266      +23     
- Partials                        224      229       +5     
Flag Coverage Δ
unittests 36.07% <68.88%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
services/api/service.go 47.02% <68.88%> (+0.71%) :arrow_up:

codecov-commenter avatar Sep 15 '23 16:09 codecov-commenter