flame icon indicating copy to clipboard operation
flame copied to clipboard

docs: Adding darkness and brightness examples

Open erickzanardo opened this issue 2 years ago • 5 comments

Description

Adds two additional examples on the image stories for brightness and darkness changes on images.

https://user-images.githubusercontent.com/835641/229366147-df4701df-901c-4d50-827e-01b57c9f57f9.mov

Checklist

  • [x] I have followed the Contributor Guide when preparing my PR.
  • [x] I have updated/added tests for ALL new/updated/fixed functionality.
  • [x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [x] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • [ ] Yes, this PR is a breaking change.
  • [x] No, this PR is not a breaking change.

Related Issues

erickzanardo avatar Apr 02 '23 16:04 erickzanardo

The blue artifact is not there anymore, but it still produces a white rectangle on the transparent background.

spydon avatar Oct 11 '23 10:10 spydon

The blue artifact is not there anymore, but it still produces a white rectangle on the transparent background.

@spydon ins't the white rectangle expected? I remember we discussed something about it internally?

erickzanardo avatar Oct 11 '23 19:10 erickzanardo

@spydon ins't the white rectangle expected? I remember we discussed something about it internally?

That was because previously flame.png had a black background, but it has a transparent background now and a fully transparent color shouldn't be brightened? Maybe that is actually a bug in our code?

spydon avatar Oct 12 '23 09:10 spydon

Hi, I randomly found this pr here and I like the image example here. It would be nice if this could be merged so it can also be found easily on the website. What's missing? Can I help here?

CodeDoctorDE avatar Aug 14 '24 16:08 CodeDoctorDE

Hi, I randomly found this pr here and I like the image example here. It would be nice if this could be merged so it can also be found easily on the website. What's missing? Can I help here?

As you can see in the video it wasn't working like intended. If you want to help you can checkout the PR, run the example and see if it works on the latest version of Flutter. :)

spydon avatar Aug 14 '24 16:08 spydon