flakestry.dev icon indicating copy to clipboard operation
flakestry.dev copied to clipboard

Published 20 hours ago • verified publisher icon flakestry

Add noscript

Open toastal opened this issue 2 years ago • 7 comments

For privacy/security I allowlist sites to enable JavaScript. When I visited the site, I got a blank white page with no information.

toastal avatar Oct 27 '23 16:10 toastal

I think a warning stating to enable js would be enough.

9glenda avatar Oct 28 '23 17:10 9glenda

Personally, I’d prefer at least the name of the application & a short description of what it does (usually there is a meta description for this anyhow).

If just says “Please enable JavaScript”, my response would be: for what? What will I get to see when I enable it?

toastal avatar Oct 28 '23 18:10 toastal

Personally, I’d prefer at least the name of the application & a short description of what it does (usually there is a meta description for this anyhow).

If just says “Please enable JavaScript”, my response would be: for what? What will I get to see when I enable it?

You're right.

I should clarify my point: I think the website doesn't have to work without javascript and just inform the user.

9glenda avatar Oct 28 '23 19:10 9glenda

There are currently no plans to support non-javascript clients.

domenkozar avatar Oct 30 '23 19:10 domenkozar

No JS would be ideal for this sort of thing IMO, but that’s this project’s call to make.

However, the bare minimum of a <noscript> with some message should be added.

toastal avatar Oct 30 '23 19:10 toastal

Sounds good! Could you make a PR that would satisfy what you'd expect?

On Mon, Oct 30, 2023, 19:27 toastal @.***> wrote:

No JS would be ideal for this sort of thing IMO, but that’s this project’s call to make.

However, the bare minimum of a

— Reply to this email directly, view it on GitHub https://github.com/flakestry/flakestry.dev/issues/27#issuecomment-1785899712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA63A3D32PTTQSWP5A3RQ3YB75RJAVCNFSM6AAAAAA6TBQLOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVHA4TSNZRGI . You are receiving this because you commented.Message ID: @.***>

domenkozar avatar Oct 30 '23 19:10 domenkozar

I don’t understand the code base with no HTML files & mustache files that aren’t obvious to me. But would expect something along the lines of:

<html lang="en">
	<head>
		<title>Flakestry<!-- This is missing; it confusingly says “Elm Land” --></title>
		<meta name="description" content="A place to find, install, and publish Nix Flakes">
	<body>
		<noscript>
			<article class="AddWrapperClassHere ScriptBlockersWon’tUseClassFromNoscriptElement">
				<header>
					<h1>Flakestry<h1>
					<p>Find, Install, &amp; Publish <a href="https://nix.dev/concepts/flakes/">Nix Flakes</a>.</p>
				</header>
				<section>
					<p>
						The Flakestry service requires JavaScript to be enabled.
						<a href="https://www.enable-javascript.com/en/">See these instructions</a> on how to enable in your browser.
						Alternatively, you may need to add an exception to your script blocker.
					</p>
				</section>
			</article>
		</noscript>

toastal avatar Oct 31 '23 07:10 toastal