pywayland
pywayland copied to clipboard
`'name'` is missing from arguments to `setuptools.setup()` in `setup.py`
I discovered this while trying to add the package to buildroot using utils/scanpypi.
@emdash The name is in the setup.cfg file, is there a reason this would also need to be added to the call in setup.py?
If memory serves, it caused breakage when trying to add pywayland as a buildroot package. They provide a tool for this,utils/scanpypi tool. If memory serves, that tool works by monkey-patching setuptools to intercept the call to setup.py and extract the arguments given. I tried utils/scanpypi on a couple other packages to see, and found that in general, this argument is supplied.
I opened this ticket as a courtesy. I am not sure what the recommended practice is, and perhaps it would make sense to submit a second patch to buildroot so that utils/scanpypi also scans setup.cfg for package metadata.
In general, I am quite new to buildroot and wayland, and I've never really spent much time with python's setuptools. I am not sure what norms apply regarding arguments to setuptools.setup(). But it seems that it could cause friction for downstream maintainers of other distributions -- besides buildroot -- if this argument is not given.