FACT_core
FACT_core copied to clipboard
Revised upload page
- removed
moment.jspackage (apparently unused for quite a while) - revised upload page:
- replaced "select" elements on upload page with dropdown menus
- inputs are always visible
- changed the styling to be more coherent
- removed validity check (it is not possible to send an invalid request using the unedited upload page because of the
requiredtags)- it could be possible to send an invalid request by manually crafting one but that would only generate an error in the frontend
- added optional filter inputs for device classes, names and vendors
- added custom autocomplete menus for inputs with dropdown menu
Nice!
Can we make the right arrow trigger the list of all possible entries?
The dropdown search on the right looks redundant to me.
Codecov Report
Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
Project coverage is 91.85%. Comparing base (
ad4d6d8) to head (144dbb7). Report is 5 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/web_interface/components/analysis_routes.py | 66.66% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
- Coverage 92.23% 91.85% -0.38%
==========================================
Files 379 378 -1
Lines 23188 20920 -2268
==========================================
- Hits 21387 19216 -2171
+ Misses 1801 1704 -97
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In addition to the commend below, I have two request but I am approving anyways to not get this stuck another week.
1. Please make the button _toggle_ the list. See the example code linked in the above comment. 2. Please make the list scroll if it overflows. For example, the following cs makes it show 10 items and add a scrollbar if it overflows.
I think I found a way to fix both issues (see https://github.com/fkie-cad/FACT_core/pull/1255/commits/144dbb73099a2ee59e8e8ec09c59674fa1831a3f)