un-indexed bufferGeometry

[lobnico]

trafficstars

Hey ! Thanks for amazing work, I ve started really recently to use it, and encountered a problem with bufferGeometry ; not setting "index" property to null will result to fatal client errors spew

<bufferGeometry position={new THREE.BufferAttribute(this._somePosAtt, 3)} normal={new THREE.BufferAttribute(this._normals, 3)} color={new THREE.BufferAttribute(this._colors, 3)} />

--> index={null} fixex evrything

three.js make explicits (attribs.index !== null), so it should be converted from undef to nul by default

[toxicFork]

Thanks for the report, I'll fix this.

[toxicFork]

If you have a simple test case it'll help too btw :)

[Place1]

I just hit this same issue :( any chance a fix is on the way? or a workaround?

[toxicFork]

Hi @Place1 PR #208 has fixed the issue, but I did not do a release since November. I'll do one when I get a chance. The workaround is to use index={null} if it would not be set, because it would default to undefined

[Place1]

Yeah I ended up doing that. No worries! Cheers for your time :)

On Sat, 17 Feb 2018 at 8:27 pm, Firtina Ozbalikci [email protected] wrote:

Hi @Place1 https://github.com/place1 PR #208 https://github.com/toxicFork/react-three-renderer/pull/208 has fixed the issue, but I did not do a release since November. I'll do one when I get a chance. The workaround is to use index={null} if it would not be set, because it would default to undefined

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/issues/146#issuecomment-366428987, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMBlqrP4qYvaK10MSygfENL31yFZjCxks5tVptzgaJpZM4LwxcM .