PSSL icon indicating copy to clipboard operation
PSSL copied to clipboard

Рефакторинг подсистемы интеграций и доработка истории интеграции

Open thvvmas opened this issue 1 year ago • 2 comments

Разработан метод получения содержимого каталога SFTP #117; Добавлены реквизиты для хранения файла в НЕ текстовом формате в историю интеграции #112. Рефакторинг общего модуля пбп_ИнтеграцииСервер

Summary by CodeRabbit

  • New Features

    • Introduced new attributes to the integration history catalog for enhanced data management.
    • Added functionality for retrieving message file data and saving exchange message files.
    • New common modules for FTP/SFTP integration and file system operations to improve system connectivity.
    • New role for viewing integration history added to enhance user permissions.
  • Bug Fixes

    • Updated versioning and improved error handling mechanisms across various modules.
  • Documentation

    • New XML files defining metadata objects and roles for better configuration management.

thvvmas avatar Oct 11 '24 10:10 thvvmas

Walkthrough

The pull request introduces enhancements to the integration management system, including new attributes in XML files, additional functions for handling file messages, and modifications to existing forms and modules. New XML files define metadata for common modules and roles, while existing modules have been updated with new procedures and functions. The changes also include updates to versioning and the addition of rights definitions, reflecting a comprehensive update to the integration framework.

Changes

File Path Change Summary
src/cf/Catalogs/пбп_ИсторияИнтеграции.xml Added attributes ИмяФайлаСообщения and ФайлСообщения to Catalog.
src/cf/Catalogs/пбп_ИсторияИнтеграции/Ext/ObjectModule.bsl Introduced function ПолучитьДанныеФайлаСообщения.
src/cf/Catalogs/пбп_ИсторияИнтеграции/Forms/ФормаЭлемента/Ext/Form.xml Renamed fields and added new groups and command.
src/cf/Catalogs/пбп_ИсторияИнтеграции/Forms/ФормаЭлемента/Ext/Form/Module.bsl Updated visibility logic, added new procedures, and refactored existing functions.
src/cf/CommonModules/пбп_ИнтеграцииFTPSFTP.xml New XML file created for пбп_ИнтеграцииFTPSFTP.
src/cf/CommonModules/пбп_ИнтеграцииFTPSFTP/Ext/Module.bsl Introduced functions for FTP/SFTP integration.
src/cf/CommonModules/пбп_ИнтеграцииСервер/Ext/Module.bsl Removed FTP/SFTP functions, added HTTP request handling functions.
src/cf/CommonModules/пбп_ИнтеграцииСлужебный.xml New XML file created for пбп_ИнтеграцииСлужебный.
src/cf/CommonModules/пбп_ИнтеграцииСлужебный/Ext/Module.bsl Introduced functions for integration history management.
src/cf/CommonModules/пбп_ОбновлениеИнформационнойБазыПБП/Ext/Module.bsl Updated version number in ПриДобавленииПодсистемы.
src/cf/CommonModules/пбп_ПредопределенныеЗначенияПереопределяемый/Ext/Module.bsl Added predefined values for integration methods.
src/cf/CommonModules/пбп_ФайловаяСистемаКлиент.xml New XML file created for пбп_ФайловаяСистемаКлиент.
src/cf/CommonModules/пбп_ФайловаяСистемаКлиент/Ext/Module.bsl Introduced procedures for file handling.
src/cf/CommonModules/пбп_ФайловаяСистемаКлиентПереадресация.xml New XML file created for пбп_ФайловаяСистемаКлиентПереадресация.
src/cf/CommonModules/пбп_ФайловаяСистемаКлиентПереадресация/Ext/Module.bsl Introduced procedures for file system client interactions.
src/cf/CommonModules/пбп_ФайловаяСистемаПереадресация/Ext/Module.bsl Converted procedures to functions, altering return behavior.
src/cf/CommonModules/пбп_ФайловаяСистемаСлужебныйКлиент.xml New XML file created for пбп_ФайловаяСистемаСлужебныйКлиент.
src/cf/CommonModules/пбп_ФайловаяСистемаСлужебныйКлиент/Ext/Module.bsl Introduced procedures for file system operations.
src/cf/Configuration.xml Updated version number and added new roles and modules.
src/cf/Roles/пбп_ПросмотрИсторииИнтеграции.xml New XML file created for role пбп_ПросмотрИсторииИнтеграции.
src/cf/Roles/пбп_ПросмотрИсторииИнтеграции/Ext/Rights.xml New XML file created for rights definitions.
src/cf/Subsystems/пбп_УправлениеИнтеграциями.xml Added new items in the <Content> section.

Possibly related PRs

  • #99: Modifications to integration management, potentially related to new attributes and functions for handling integration data.
  • #113: Adds functions for SFTP, relevant to new file handling and integration features introduced.

Suggested labels

bug

Suggested reviewers

  • ivanmolodec

🐇 In the garden where changes bloom,
New attributes and functions loom.
With files and roles, we weave a tale,
Integration's dance will never fail!
Hopping through code, we celebrate,
A project reborn, it’s never too late! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 11 '24 10:10 coderabbitai[bot]

Failed

  • C Reliability Rating on New Code (is worse than A)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Analysis Details

97 Issues

  • Bug 3 Bugs
  • Vulnerability 2 Vulnerabilities
  • Code Smell 92 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: PSSL

View in SonarQube

Passed

Analysis Details

41 Issues

  • Bug 0 Bugs
  • Vulnerability 2 Vulnerabilities
  • Code Smell 39 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: PSSL

View in SonarQube

Passed

Analysis Details

26 Issues

  • Bug 0 Bugs
  • Vulnerability 2 Vulnerabilities
  • Code Smell 24 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.40% Estimated after merge)

Project ID: PSSL

View in SonarQube