arduino icon indicating copy to clipboard operation
arduino copied to clipboard

Published 20 hours ago • verified publisher icon firmata

Fix compilation for UNOR4

Open pgrawehr opened this issue 1 year ago • 2 comments

pgrawehr avatar Sep 09 '24 05:09 pgrawehr

If I understand the fix correctly, it appears that all digital pins will be marked as PWM capable, but this doesn't appear to be true based on the pinout for the MINIMA or WIFI.

zfields avatar Sep 09 '24 13:09 zfields

I need to check that again, but that's what the mapping was doing already, except that it used a macro that basically caused a circular dependency. Something is broken there, and I currently don't know why it ever worked.

pgrawehr avatar Sep 09 '24 13:09 pgrawehr

@zfields Now this makes more sense. It seems the previously conflicting definitions where now resolved and it just compiles without these definitions. I don't have the board, so I can only test the compilation, not whether it works.

pgrawehr avatar Sep 12 '24 19:09 pgrawehr

I don't have one either. I say let's merge it for now, and see if anyone complains.

zfields avatar Sep 12 '24 19:09 zfields

Ok, fine with me. I'll fix it for ConfigurableFirmata as well, has the exactly same issue.

pgrawehr avatar Sep 12 '24 19:09 pgrawehr