arduino icon indicating copy to clipboard operation
arduino copied to clipboard

break out I2C and Servo features into classes

Open soundanalogous opened this issue 9 years ago • 4 comments

To help simplify maintenance of all of the StandardFirmata* variants as well as improve code readability (especially in the massive sysexCallback switch statement), break out the Servo, I2C and Serial features into classes. This also enables conditionally including these features so that StandardFirmataEthernet and StandardFirmataEthernetPlus can be merged (user comments or uncomments Serial feature include to add or remove the extra functionality) - in the same way, Serial and other new functionality can be conditionally added to StandardFirmataWiFi, StandardFirmataBLE, etc.

The only downside is this will increase the memory usage somewhat.

soundanalogous avatar Jan 10 '16 19:01 soundanalogous

start with Serial

soundanalogous avatar Jan 10 '16 21:01 soundanalogous

going to try to get this into 2.6 to maintain sanity

soundanalogous avatar Jan 11 '16 02:01 soundanalogous

Made good progress on this today for Serial: https://github.com/firmata/arduino/pull/268.

soundanalogous avatar Jan 11 '16 06:01 soundanalogous

Serial is merged. Changing issue name to reflect work remaining.

soundanalogous avatar Jan 16 '16 22:01 soundanalogous