nativescript-contacts icon indicating copy to clipboard operation
nativescript-contacts copied to clipboard

app breaks because image-source was not properly imported

Open ovaltechnologiesinc opened this issue 3 years ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/nativescript-contacts/contact-helper.android.js b/node_modules/nativescript-contacts/contact-helper.android.js
index 11d7474..cc346e3 100644
--- a/node_modules/nativescript-contacts/contact-helper.android.js
+++ b/node_modules/nativescript-contacts/contact-helper.android.js
@@ -1,6 +1,6 @@
 var appModule = require("@nativescript/core/application");
 var KnownLabel = require("./known-label");
-var imageSource = require("image-source");
+var imageSource = require('@nativescript/core/image-source');
 
 /* missing constants from the {N} */
 var TYPE_CUSTOM = 0;
diff --git a/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar b/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar
new file mode 100644
index 0000000..27f9619
Binary files /dev/null and b/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar differ

This issue body was partially generated by patch-package.

ovaltechnologiesinc avatar Feb 05 '22 06:02 ovaltechnologiesinc

Can we get this merged please ?

lewebsimple avatar Aug 18 '22 18:08 lewebsimple