firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

vCPU Hotplug Performance Tests

Open ghost opened this issue 1 year ago • 1 comments

Changes

Add non-CI performance tests for vCPU hot-plugging

Reason

To facilitate the performance analysis of vCPU hot-plugging (should it need to be analysed again)

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • [ ] Commits meet contribution quality standards.

  • [ ] This functionality cannot be added in rust-vmm.

ghost avatar Aug 06 '24 12:08 ghost

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (a541725) to head (1cb9072).

Files Patch % Lines
src/vmm/src/lib.rs 33.33% 4 Missing :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/vcpu-hotplug    #4722      +/-   ##
========================================================
- Coverage                 81.95%   81.94%   -0.01%     
========================================================
  Files                       257      257              
  Lines                     31762    31768       +6     
========================================================
+ Hits                      26031    26033       +2     
- Misses                     5731     5735       +4     
Flag Coverage Δ
5.10-c5n.metal 82.06% <33.33%> (-0.01%) :arrow_down:
5.10-m5n.metal 82.05% <33.33%> (-0.01%) :arrow_down:
5.10-m6a.metal 81.37% <33.33%> (-0.02%) :arrow_down:
5.10-m6g.metal 79.21% <ø> (ø)
5.10-m6i.metal 82.04% <33.33%> (-0.01%) :arrow_down:
5.10-m7g.metal 79.21% <ø> (ø)
6.1-c5n.metal 82.06% <33.33%> (-0.01%) :arrow_down:
6.1-m5n.metal 82.05% <33.33%> (-0.01%) :arrow_down:
6.1-m6a.metal 81.37% <33.33%> (-0.02%) :arrow_down:
6.1-m6g.metal 79.21% <ø> (ø)
6.1-m6i.metal 82.05% <33.33%> (-0.01%) :arrow_down:
6.1-m7g.metal 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 07 '24 12:08 codecov[bot]