firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Hotplug Integration Tests

Open ghost opened this issue 1 year ago • 3 comments

Changes

Add functional integration tests for vCPU hot-plugging

Reason

To ensure that everything works as intended

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • [x] If a specific issue led to this PR, this PR closes the issue.
  • [x] The description of changes is clear and encompassing.
  • [x] Any required documentation changes (code and docs) are included in this PR.
  • [x] API changes follow the Runbook for Firecracker API changes.
  • [x] User-facing changes are mentioned in CHANGELOG.md.
  • [x] All added/changed functionality is tested.
  • [x] New TODOs link to an issue.
  • [x] Commits meet contribution quality standards.

  • [x] This functionality cannot be added in rust-vmm.

ghost avatar Jul 24 '24 15:07 ghost

Will the hotplug features possibly land in 1.9?

kanpov avatar Jul 28 '24 15:07 kanpov

Will the hotplug features possibly land in 1.9?

Hi @kanpov, thanks for your interest in the vcpu hotplugging feature! We currently do not have an estimate of when/if hotplugging will be released, as we are still in a prototyping/researching phase to assess whether the feature would even have acceptable performance for Firecracker's usecase. Could you describe your usecase for hotplugging a bit more over in our tracking issue? That will help us with prioritization and assessment of the feature :)

roypat avatar Jul 29 '24 06:07 roypat

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 81.95%. Comparing base (a541725) to head (f050f98). :warning: Report is 1 commits behind head on feature/vcpu-hotplug.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feature/vcpu-hotplug    #4704   +/-   ##
=====================================================
  Coverage                 81.95%   81.95%           
=====================================================
  Files                       257      257           
  Lines                     31762    31762           
=====================================================
  Hits                      26031    26031           
  Misses                     5731     5731           
Flag Coverage Δ
5.10-c5n.metal 82.07% <ø> (ø)
5.10-m5n.metal 82.06% <ø> (+<0.01%) :arrow_up:
5.10-m6a.metal 81.38% <ø> (ø)
5.10-m6g.metal 79.21% <ø> (ø)
5.10-m6i.metal 82.06% <ø> (+<0.01%) :arrow_up:
5.10-m7g.metal 79.21% <ø> (ø)
6.1-c5n.metal 82.06% <ø> (-0.01%) :arrow_down:
6.1-m5n.metal 82.05% <ø> (ø)
6.1-m6a.metal 81.38% <ø> (ø)
6.1-m6g.metal 79.21% <ø> (ø)
6.1-m6i.metal 82.05% <ø> (ø)
6.1-m7g.metal 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 07 '24 10:08 codecov[bot]