firecracker
firecracker copied to clipboard
[WIP] refactor mock-based testing rpc_interface.rs
This was the easiest way to see the impact of this experiment in codecov's nice UI, sorry
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.
PR Checklist
- [ ] If a specific issue led to this PR, this PR closes the issue.
- [ ] The description of changes is clear and encompassing.
- [ ] Any required documentation changes (code and docs) are included in this PR.
- [ ] API changes follow the Runbook for Firecracker API changes.
- [ ] User-facing changes are mentioned in
CHANGELOG.md. - [ ] All added/changed functionality is tested.
- [ ] New
TODOs link to an issue. - [ ] Commits meet contribution quality standards.
- [ ] This functionality cannot be added in
rust-vmm.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.37%. Comparing base (
bd18d01) to head (8ddf9e9). Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4646 +/- ##
==========================================
- Coverage 84.38% 84.37% -0.02%
==========================================
Files 249 249
Lines 27452 27452
==========================================
- Hits 23165 23162 -3
- Misses 4287 4290 +3
| Flag | Coverage Δ | |
|---|---|---|
| 5.10-c5n.metal | 84.60% <ø> (-0.02%) |
:arrow_down: |
| 5.10-m5n.metal | 84.58% <ø> (-0.02%) |
:arrow_down: |
| 5.10-m6a.metal | 83.87% <ø> (-0.02%) |
:arrow_down: |
| 5.10-m6g.metal | 80.94% <ø> (+0.02%) |
:arrow_up: |
| 5.10-m6i.metal | 84.57% <ø> (-0.02%) |
:arrow_down: |
| 5.10-m7g.metal | 80.94% <ø> (+0.02%) |
:arrow_up: |
| 6.1-c5n.metal | 84.60% <ø> (-0.02%) |
:arrow_down: |
| 6.1-m5n.metal | 84.58% <ø> (-0.02%) |
:arrow_down: |
| 6.1-m6a.metal | 83.88% <ø> (-0.01%) |
:arrow_down: |
| 6.1-m6g.metal | 80.94% <ø> (+0.03%) |
:arrow_up: |
| 6.1-m6i.metal | 84.57% <ø> (-0.02%) |
:arrow_down: |
| 6.1-m7g.metal | 80.94% <ø> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just to confirm, so unit/integ tests don't cover every variant of the
matchstatement?
If the match arm is of the form Action::Something(bla) => other_function_with_unittests(bla), then no, I didn't consider that very useful. More complex cases are exercised by the rust integration tests now