firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Published 20 hours ago • verified publisher icon firecracker-microvm

Remove multi irq support for mmio devices

Open ShadowCurse opened this issue 1 year ago • 4 comments

Currently Firecracker have an ability to create multiple irqs for MMIO devices. These irqs are store in the MMIODeviceInfo struct here. As per discussion here we would like to remove this "multi irq" configuration as Firecracker never uses for more than 1 irq per device. Also MMIO devices can not have more than 1 irq anyway.

The change can be as simple as replacing Vec<u32> with Option<NonZeroU32> and updating all places where this field is used.

Checks

  • [ ] Have you searched the Firecracker Issues database for similar requests?
  • [ ] Have you read all the existing relevant Firecracker documentation?
  • [ ] Have you read and understood Firecracker's core tenets?

ShadowCurse avatar Apr 02 '24 15:04 ShadowCurse

Hi everyone,

We're a group at UT Austin and we're interested in picking this issue up.

andr3wy avatar Apr 03 '24 21:04 andr3wy

Hi @andr3wy, you are welcome to work on this.

ShadowCurse avatar Apr 04 '24 10:04 ShadowCurse

If anyone is interested in taking this issue, you can reuse already existing PR @andr3wy created: #4601

ShadowCurse avatar Oct 09 '24 13:10 ShadowCurse

If anyone is interested in taking this issue, you can reuse already existing PR @andr3wy created: #4601

Note that the implementation there is completely done, but for some reason the CI fails which we havent had a chance to look into yet

roypat avatar Oct 16 '24 13:10 roypat