firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Reset dirty log on full snapshot path

Open RomanKovtyukh opened this issue 1 year ago • 0 comments

Changes

  • Added the get_dirty_bitmap on the full snapshot path

Reason

  • The full snapshot path doesn’t call Vmm:get_dirty_bitmap thus doesn’t call KVM_GET_DIRTY_LOG which doesn’t reset dirty pages.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.

  • [ ] The description of changes is clear and encompassing.

  • [ ] Any required documentation changes (code and docs) are included in this PR.

  • [ ] API changes follow the Runbook for Firecracker API changes.

  • [ ] User-facing changes are mentioned in CHANGELOG.md.

  • [ ] All added/changed functionality is tested.

  • [ ] New TODOs link to an issue.

  • [ ] Commits meet contribution quality standards.

  • [ ] This functionality cannot be added in rust-vmm.

RomanKovtyukh avatar Jan 19 '24 15:01 RomanKovtyukh