firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Published 20 hours ago • verified publisher icon firecracker-microvm

Todo

Open StonewallJohnson opened this issue 2 years ago • 1 comments

Changes

  • Added doc string to Endpoint::new()
  • Found better name for app_metrics

Reason

Resolve TODOs according to #3273

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • ☑ If a specific issue led to this PR, this PR closes the issue.
  • ☑ The description of changes is clear and encompassing.
  • ☑ Any required documentation changes (code and docs) are included in this PR.
  • ☑ API changes follow the Runbook for Firecracker API changes.
  • ☑ User-facing changes are mentioned in CHANGELOG.md.
  • ☑ All added/changed functionality is tested.
  • ☑ New TODOs link to an issue.
  • ☑ Commits meet contribution quality standards.
  • [ ] This functionality cannot be added in rust-vmm.

StonewallJohnson avatar Apr 26 '23 23:04 StonewallJohnson

Hi @StonewallJohnson ,

Thanks for your contribution. Are you still following this PR? Can you address @roypat comments?

xmarcalx avatar Aug 07 '23 10:08 xmarcalx