firecracker
firecracker copied to clipboard
fix todo: log virtio address
Changes
Resolves TODO: log address see https://github.com/firecracker-microvm/firecracker/issues/3273.
Reason
Resolves TODO.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.
PR Checklist
- [x] If a specific issue led to this PR, this PR closes the issue.
- [x] The description of changes is clear and encompassing.
- [x] Any required documentation changes (code and docs) are included in this PR.
- [x] API changes follow the Runbook for Firecracker API changes.
- [x] User-facing changes are mentioned in
CHANGELOG.md. - [x] All added/changed functionality is tested.
- [x] New
TODOs link to an issue. - [x] Commits meet contribution quality standards.
- [ ] This functionality cannot be added in
rust-vmm.
@roypat @JonathanWoollett-Light I fixed this in a new PR because the old PR kind of got messy with the signing of commits
I think the commit titled should be reworded, I would suggest: fix: log virtio address
@sladyn98 Could you please rebase and resolve merge conflicts.
@JonathanWoollett-Light Yeah sorry completely forgot about this : )
@JonathanWoollett-Light Changed commit name and resolved conflicts
Codecov Report
Patch coverage has no change and project coverage change: -0.01% :warning:
Comparison is base (
6bf22c2) 82.66% compared to head (b54724a) 82.66%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 221 221
Lines 28192 28191 -1
==========================================
- Hits 23306 23305 -1
Misses 4886 4886
| Flag | Coverage Δ | |
|---|---|---|
| 4.14-c7g.metal | 78.12% <0.00%> (+<0.01%) |
:arrow_up: |
| 4.14-m5d.metal | 79.91% <0.00%> (+<0.01%) |
:arrow_up: |
| 4.14-m6a.metal | 79.05% <0.00%> (+<0.01%) |
:arrow_up: |
| 4.14-m6g.metal | 78.12% <0.00%> (+<0.01%) |
:arrow_up: |
| 4.14-m6i.metal | 79.90% <0.00%> (+<0.01%) |
:arrow_up: |
| 5.10-c7g.metal | 81.07% <0.00%> (+<0.01%) |
:arrow_up: |
| 5.10-m5d.metal | 82.59% <0.00%> (-0.01%) |
:arrow_down: |
| 5.10-m6a.metal | 81.84% <0.00%> (+<0.01%) |
:arrow_up: |
| 5.10-m6g.metal | 81.07% <0.00%> (+<0.01%) |
:arrow_up: |
| 5.10-m6i.metal | 82.59% <0.00%> (+<0.01%) |
:arrow_up: |
| 6.1-c7g.metal | 81.07% <0.00%> (+<0.01%) |
:arrow_up: |
| 6.1-m5d.metal | 82.59% <0.00%> (-0.01%) |
:arrow_down: |
| 6.1-m6a.metal | 81.84% <0.00%> (+<0.01%) |
:arrow_up: |
| 6.1-m6g.metal | 81.07% <0.00%> (+<0.01%) |
:arrow_up: |
| 6.1-m6i.metal | 82.59% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files Changed | Coverage Δ | |
|---|---|---|
| src/vmm/src/devices/virtio/queue.rs | 94.65% <0.00%> (+0.29%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @sladyn98 ,
This PR has still some style issue and not passing the PR. Are yous till interested in fix those issues and merge your changes?