firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

[Feature Request] Create integration test for testing snapshot restore on CPUs with different TSC frequencies.

Open alsrdn opened this issue 3 years ago • 2 comments

Feature Request

Create integration test for testing snapshot restore on CPUs with different TSC frequencies.

Describe the desired solution

Create a integration test to validate this code: https://github.com/firecracker-microvm/firecracker/blob/f2f8802122cf20fa043600290dcc938c96b9611d/src/vmm/src/builder.rs#L482

Describe possible alternatives

We need 2 things for this:

  • a snapshot saved on S3 on a CPU that has a certain TSC frequency
  • an integration test that is being run on a CPU with a different frequency

[Author TODO: How do you work around not having this feature?]

Additional context

[Author TODO: Add additional context about this feature request here.]

Checks

  • [x] Have you searched the Firecracker Issues database for similar requests?
  • [x] Have you read all the existing relevant Firecracker documentation?
  • [x] Have you read and understood Firecracker's core tenets?

alsrdn avatar May 02 '22 16:05 alsrdn

We have tests for restoring snapshots across different x86_64 CPU models in https://github.com/firecracker-microvm/firecracker/blob/main/.buildkite/pipeline_cross.py, however we do not specifically exercise any TSC related functionality. I'm marking this issue as Parked, as we also do not plan to investigate this further at the moment.

roypat avatar Oct 09 '23 10:10 roypat

Cover negative test cases as mentioned in #2624

wearyzen avatar Nov 13 '23 11:11 wearyzen