firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Separate Rate Limiter from core virtio implementation

Open andreeaflorescu opened this issue 5 years ago • 1 comments

Right now the virtio device implementation is tightly coupled with the rate limiter. We should have the rate limiter functionality as a plugin for Virtio Devices for two reasons:

  • Separation of concerns. Separate the core emulation from the rate limiter. This should also reduce the duplication of code in Block Devices for example where we parse requests twice.
  • Consuming the virtio implementation from rust-vmm (when it is available).

andreeaflorescu avatar Apr 08 '20 15:04 andreeaflorescu

This would nice to have. Setting low priority right now.

alsrdn avatar Mar 22 '22 09:03 alsrdn

Marking this as 'not planned' for now, as we do not really see how this could be done easily, and the benefits of this as a stand-alone change are low. Should a future task require this, we can revisit this issue.

roypat avatar Mar 04 '24 12:03 roypat