firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Handle epoll errors when handling device events

Open iulianbarbu opened this issue 5 years ago • 2 comments

At the moment, the current device event handling implementation, for net, block and vsock devices, does not handle errors which might occur on the epoll registered event fds (EPOLLHUP, EPOLLRDHUP, EPOLERR). We must unregister these fds for which we receieved error events.

iulianbarbu avatar Feb 24 '20 09:02 iulianbarbu

I don't think we should unregister in case of any of those events. But all devices do need to gracefully handle them.

L.E. apparently the EPOLLHUP cannot be consumed and the fd must be unregistered from epoll otherwise it will keep pinging.

acatangiu avatar May 29 '20 06:05 acatangiu

In the meanwhile we switched to using the EventHandler from rust-vmm. We should check if it handles these events or if we should move this issue there.

serban300 avatar May 17 '22 08:05 serban300

As @serban300 mentioned we now use https://github.com/rust-vmm/event-manager. Closing as this issue does not relate to Firecracker code.

JonathanWoollett-Light avatar Apr 11 '23 08:04 JonathanWoollett-Light