php-jwt icon indicating copy to clipboard operation
php-jwt copied to clipboard

Deprecation warnings on PHP 8.4

Open ADmad opened this issue 1 year ago • 1 comments

src/JWT.php:199
Firebase\JWT\JWT::encode(): Implicitly marking parameter $keyId as nullable is deprecated, the explicit nullable type must be used instead

src/JWK.php:55
Firebase\JWT\JWK::parseKeySet(): Implicitly marking parameter $defaultAlg as nullable is deprecated, the explicit nullable type must be used instead

src/JWK.php:96
Firebase\JWT\JWK::parseKey(): Implicitly marking parameter $defaultAlg as nullable is deprecated, the explicit nullable type must be used instead

ADmad avatar Jul 25 '24 11:07 ADmad

Confirmed. Would be great to get this merged and released - PHP 8.4 is alpha2 now and frameworks start implementing compatibility, libraries should have compatible releases.

lolli42 avatar Jul 29 '24 12:07 lolli42

Ping.

Note current CI is (unnoticed) red, which is fixed by PR #572 as well as drive-by.

Note there is PR #573 as dupe already.

lolli42 avatar Aug 06 '24 16:08 lolli42