php-jwt icon indicating copy to clipboard operation
php-jwt copied to clipboard

fix: validate iat and nbf on payload

Open christiandavilakoobin opened this issue 1 year ago • 2 comments

If a JWT has a nonumeric iat or nbf value, it throws a FATAL error when validating the field.

christiandavilakoobin avatar Jun 19 '24 14:06 christiandavilakoobin

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 19 '24 14:06 google-cla[bot]

overlaps with #453

robocoder avatar Jan 03 '25 23:01 robocoder

I like your implementation better than https://github.com/firebase/php-jwt/pull/453/files because it's simpler - but do you think you could add some tests like in the other PR? If so, please also include the exception message in expectExceptionMessage(...)

bshaffer avatar Apr 15 '25 21:04 bshaffer

Hi @bshaffer! You mean this?

christiandavilakoobin avatar Apr 16 '25 08:04 christiandavilakoobin

@christiandavilakoobin you need to sign the CLA before I can merge this!

bshaffer avatar Apr 16 '25 16:04 bshaffer

@bshaffer it says I signed tje CLA on Jun 19, 2024 08:00 PDT

christiandavilakoobin avatar Apr 16 '25 19:04 christiandavilakoobin

@bshaffer I just saw I push with another mail. I've signed the CLA with that email too.

christiandavilakoobin avatar Apr 16 '25 19:04 christiandavilakoobin

@christiandavilakoobin thank you! it worked

bshaffer avatar Apr 16 '25 19:04 bshaffer