flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

Published 20 hours ago • verified publisher icon firebase

feat(app_check, mobile): add option to pass debugTokens in initialization

Open xVemu opened this issue 1 year ago • 7 comments

Description

This feature allows a developer to use a pre-generated debug token instead of one that is generated at runtime. It's useful in CI environments, where you don't have an option to copy token from logs and paste it to Firebase Console.

Related Issues

Fix for: https://github.com/firebase/flutterfire/issues/11719

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] The analyzer (melos run analyze) does not report any problems on my PR.
  • [ ] I read and followed the Flutter Style Guide.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [x] No, this is not a breaking change.

xVemu avatar Jul 26 '24 12:07 xVemu

Hello @xVemu, thanks for your PR, could you add some tests in the tests/integration_test/firebase_app_check

Lyokone avatar Jul 30 '24 12:07 Lyokone

@Lyokone something like this?

xVemu avatar Aug 01 '24 10:08 xVemu

Thanks, I'll have a look at the API (we might want to have appleDebugToken instead of iosDebugToken). But otherwise it looks good :)

Lyokone avatar Aug 02 '24 08:08 Lyokone

@xVemu any update for that?

Fudal avatar Sep 23 '24 11:09 Fudal

@xVemu any update for that?

I guess we have to wait for Firebase team?

xVemu avatar Sep 23 '24 12:09 xVemu

@xVemu did you notice that some tests are failing?

adonisRodxander avatar Oct 08 '24 23:10 adonisRodxander

@xVemu did you notice that some tests are failing?

~~Yep, I assume that's because I haven't changed pubspec for related packages.~~

xVemu avatar Oct 09 '24 07:10 xVemu

@xVemu have you got anytime to fix this ?

MoaidAlrazhy avatar Nov 13 '24 13:11 MoaidAlrazhy

@xVemu have you got anytime to fix this ?

~Fix what?~

xVemu avatar Nov 13 '24 15:11 xVemu

@xVemu have you got anytime to fix this ?

Fix what?

the failing checks below that are blocking the PR.

MoaidAlrazhy avatar Nov 13 '24 15:11 MoaidAlrazhy

@xVemu are you able to tell who should doing something to merge it?

Fudal avatar Dec 04 '24 11:12 Fudal

@xVemu can you have a look at the failing checks, please?

furkankurt avatar Jan 03 '25 13:01 furkankurt

Closing as this is being worked on in this PR: https://github.com/firebase/flutterfire/pull/16942

russellwheatley avatar May 13 '25 13:05 russellwheatley