firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Fix the extension overwriting the .firebase RC file when manually changed

Open rrousselGit opened this issue 1 year ago • 1 comments
trafficstars

Description

This is done by using the .firebaseRC as the source of truth for the project ID, instead of the currentProjectId signal.

Scenarios Tested

I'm not sure how to test this, as this is a race condition and happens at an undertermined point in time.

Sample Commands

rrousselGit avatar Sep 21 '24 15:09 rrousselGit

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (launch.fdc-pp@9017011). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             launch.fdc-pp    #7710   +/-   ##
================================================
  Coverage                 ?   55.61%           
================================================
  Files                    ?      417           
  Lines                    ?    28474           
  Branches                 ?     5823           
================================================
  Hits                     ?    15835           
  Misses                   ?    12470           
  Partials                 ?      169           
Flag Coverage Δ
55.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 21 '24 15:09 codecov-commenter