firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

feat: support source deploy option

Open matthewaptaylor opened this issue 1 year ago • 1 comments

Description

This PR adds an option to the Firebase CLI to override the functions.source config option on firebase deploy. This is much like the option which overrides the public directory when deploying to Hosting.

The use case is where a user deploys a functions package whose structure is not supported by Firebase, such as a monorepo package. When deploying a functions package in a monorepo, a common strategy is to create a directory which contains the functions and other internal monorepo dependencies, and deploy that. One such example is isolate-package. Other strategies are mentioned in #653.

Scenarios Tested

  • Tested running firebase deploy --only functions --source apps/functions/deploy, which deploys the deploy directory.
  • Tested running firebase deploy --only functions, which deploys the folder specified in firebase.json.

Sample Commands

firebase deploy --only functions --source apps/functions/deploy firebase deploy --only functions -s apps/functions/deploy firebase deploy --source apps/functions/deploy firebase deploy -s apps/functions/deploy

matthewaptaylor avatar May 13 '24 04:05 matthewaptaylor

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 13 '24 04:05 google-cla[bot]