firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Strengthen typing of Runtimes+Langauges and their support timelines.

Open inlined opened this issue 1 year ago • 1 comments
trafficstars

  • Factors out Runtimes into a new file so that they can be imported into firebaseConfig.ts and have a single source of truth and prevent the error encountered in https://github.com/firebase/firebase-tools/issues/6774#issuecomment-1953399977
  • Adds a formal concept of languages and the ability to discriminate runtimes per language
  • Makes all information about a runtime table driven so there can never be a runtime without all necessary metadata
  • Adds the ability to dynamically fetch the latest runtime for a language
  • Adds support timelines for all runtimes
  • Unifies runtime support checks across all runtimes/languages. There are now separate warnings for when deprecation is upcoming (90d), when a runtime is deprecated, and when a runtime is decommissioned.

inlined avatar Mar 10 '24 22:03 inlined

Codecov Report

Attention: Patch coverage is 64.42308% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 54.27%. Comparing base (27088cd) to head (bca4ff7).

Files Patch % Lines
src/deploy/functions/prepare.ts 11.11% 8 Missing :warning:
src/deploy/functions/runtimes/python/index.ts 45.45% 6 Missing :warning:
src/deploy/functions/runtimes/supported.ts 86.48% 2 Missing and 3 partials :warning:
src/emulator/controller.ts 16.66% 5 Missing :warning:
src/deploy/functions/runtimes/index.ts 20.00% 4 Missing :warning:
src/gcp/cloudfunctions.ts 25.00% 1 Missing and 2 partials :warning:
src/emulator/functionsEmulator.ts 0.00% 2 Missing :warning:
src/gcp/cloudfunctionsv2.ts 33.33% 0 Missing and 2 partials :warning:
src/deploy/functions/runtimes/node/index.ts 80.00% 1 Missing :warning:
src/functional.ts 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6866      +/-   ##
==========================================
+ Coverage   54.26%   54.27%   +0.01%     
==========================================
  Files         352      353       +1     
  Lines       24536    24573      +37     
  Branches     5083     5090       +7     
==========================================
+ Hits        13315    13338      +23     
- Misses      10007    10022      +15     
+ Partials     1214     1213       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 10 '24 23:03 codecov-commenter