firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Remove development-only files from Next.js deployments

Open leoortizz opened this issue 1 year ago • 3 comments

Description

Remove development-only files from deployed files. Closes #6715

Scenarios Tested

see test case added in 1f579d7601b63a0d3d9f3da5e7f3afb27f89cdfb

Sample Commands

leoortizz avatar Jan 31 '24 21:01 leoortizz

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (cecf08b) to head (b6b946d).

Files Patch % Lines
src/frameworks/next/utils.ts 28.57% 5 Missing :warning:
src/frameworks/next/index.ts 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6731      +/-   ##
==========================================
- Coverage   54.56%   54.56%   -0.01%     
==========================================
  Files         355      355              
  Lines       24723    24731       +8     
  Branches     5107     5108       +1     
==========================================
+ Hits        13490    13494       +4     
- Misses      10013    10017       +4     
  Partials     1220     1220              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 27 '24 19:02 codecov-commenter

Would be great if we didn't copy those files to start with but that would probably make the code more complex, wdyt?

jamesdaniels avatar Feb 28 '24 18:02 jamesdaniels

Would be great if we didn't copy those files to start with but that would probably make the code more complex, wdyt?

indeed, I can make that change. I thought it would be slower than just removing the files but it's probably similar

leoortizz avatar Feb 28 '24 18:02 leoortizz