firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

feat: display meaningful error msg when cannot determine target

Open 9kubczas4 opened this issue 1 year ago • 2 comments

Description

Display a meaningful error message when the cannot determine the target. It would be helpful in scenarios when the user changed default configuration names, for example, production to live. This change allows us to understand better what needs to be done by the developer to fix this issue.

Previous error message: Error: Configuration 'production' is not set in the workspace. Current error message: Unable to determine the application to deploy, specify a target via the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable.

Related to #6138.

Scenarios Tested

  1. Create Angular application (v17)
  2. Rename the production configuration to live - adjust angular.json
  3. Deploy to Firebase using FIREBASE_FRAMEWORKS_BUILD_TARGET='live' firebase deploy

9kubczas4 avatar Dec 07 '23 21:12 9kubczas4

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 54.79%. Comparing base (b82594f) to head (6de3c23). Report is 1 commits behind head on master.

Files Patch % Lines
src/frameworks/angular/utils.ts 14.28% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6594      +/-   ##
==========================================
+ Coverage   54.61%   54.79%   +0.18%     
==========================================
  Files         356      358       +2     
  Lines       24892    25015     +123     
  Branches     5136     5157      +21     
==========================================
+ Hits        13594    13708     +114     
- Misses      10066    10072       +6     
- Partials     1232     1235       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 07 '23 22:12 codecov-commenter

Few small things, thanks

jamesdaniels avatar Dec 08 '23 03:12 jamesdaniels