firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

add additional site config information to hosting:sites:list

Open bkendall opened this issue 3 years ago • 1 comments

Description

There's useful information in Hosting's API that we can present in the CLI - specifically if Cloud Logging is enabled or how many versions are retained. We should display that!

image

This is a tiny step towards addressing #215 which is ooollllddddd haha. But to be able to view this in the CLI would be good.

bkendall avatar Oct 07 '22 21:10 bkendall

Codecov Report

Base: 56.06% // Head: 56.07% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (1d73c9b) compared to base (8f18fba). Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5087      +/-   ##
==========================================
+ Coverage   56.06%   56.07%   +0.01%     
==========================================
  Files         307      307              
  Lines       20635    20643       +8     
  Branches     4166     4168       +2     
==========================================
+ Hits        11568    11575       +7     
  Misses       8066     8066              
- Partials     1001     1002       +1     
Impacted Files Coverage Δ
src/hosting/api.ts 82.50% <87.50%> (+0.26%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 07 '22 21:10 codecov-commenter

This is a great idea! Two suggestions/requests:

  1. Please include this information in the return value of firebase hosting:list:sites, rather than simply displaying it. This is important for using the CLI as a module.
  2. Please allow access to even more of the information available via the Hosting API. For instance, I'd love a command like firebase hosting:list:releases <siteId> that returns the output of apiClient.get(`/projects/${project}/sites/${site}/releases`). Alternatively, to avoid introducing another command, maybe return some key information about the current release for each site in firebase hosting:list:sites (e.g., message, releaseTime, version.status).

EvanCesanek avatar Feb 28 '23 15:02 EvanCesanek