firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard
verified publisher icon firebase

fix: send `x-goog-upload-status: final` in Firebase storage emulator `finalizeOneShotUpload`

Open valeriangalliat opened this issue 3 years ago • 0 comments

Description

Fixes https://github.com/firebase/firebase-tools/issues/4959.

It appears the emulator doesn't send x-goog-upload-status in finalizeOneShotUpload, and the Firebase JS SDK expects this header to be set otherwise crashes with a "unknown error". This PR adds this header to make the uploads complete.

Scenarios Tested

  • Resumable upload against emulator

valeriangalliat avatar Sep 08 '22 13:09 valeriangalliat