firebase-tools
firebase-tools copied to clipboard
Fix storage gcs conformance tests
trafficstars
Description
- Fixes remaining metadata bugs in https://github.com/firebase/firebase-tools/issues/3398#issuecomment-1159821364 by setting appropriate default metadata fields depending on which API is used
- Introduces media upload protocol support to both GCS and Firebase APIs
- Adds support to GCS API for
/storage/v1/b/:bucketId/o/:objectIdurl pattern
Scenarios Tested
Sample Commands
Codecov Report
Merging #4869 (3f1f3cd) into master (5728643) will decrease coverage by
0.19%. The diff coverage is4.29%.
@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
- Coverage 56.93% 56.73% -0.20%
==========================================
Files 288 288
Lines 19062 19110 +48
Branches 3775 3792 +17
==========================================
- Hits 10853 10843 -10
- Misses 7290 7350 +60
+ Partials 919 917 -2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/emulator/storage/apis/firebase.ts | 4.05% <0.00%> (-0.04%) |
:arrow_down: |
| src/emulator/storage/apis/gcloud.ts | 5.33% <0.00%> (-1.09%) |
:arrow_down: |
| src/emulator/storage/files.ts | 23.75% <0.00%> (-1.15%) |
:arrow_down: |
| src/emulator/storage/upload.ts | 72.72% <33.33%> (-5.28%) |
:arrow_down: |
| src/emulator/storage/metadata.ts | 42.05% <71.42%> (-4.62%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.