firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Refactor runtime to spin up http server at startup instead of per invocation.

Open taeold opened this issue 3 years ago • 2 comments

taeold avatar Aug 11 '22 21:08 taeold

Current dependencies on/for this PR:

  • master
    • PR #4955 Graphite
      • PR #4949 Graphite
        • PR #4861 Graphite 👈
          • PR #4867 Graphite
            • PR #4886 Graphite
              • PR #4964 Graphite
              • PR #4947 Graphite

This comment was auto-generated by Graphite.

taeold avatar Aug 11 '22 21:08 taeold

Codecov Report

Merging #4861 (3d187f1) into master (3607b55) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4861   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files         291      291           
  Lines       19341    19341           
  Branches     3855     3855           
=======================================
  Hits        10960    10960           
  Misses       7453     7453           
  Partials      928      928

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 12 '22 20:08 codecov-commenter

I'm blocking merging the PR until https://github.com/firebase/firebase-tools/issues/4807 is closed. It seems like Emulator refactoring is affecting many developers.

taeold avatar Sep 01 '22 00:09 taeold

Graphite Merge Job

Current status: ⛔ Merge stopped

This pull request was previously queued to merge as part of a stack. It could not be merged because optional checks are failing. To continue, please 1) fix the tests and start a new merge or 2) manually merge past the failing tests.

This comment was auto-generated by Graphite.

Job Reference: fQxj0krvewveagu4c7Lc

taeold avatar Sep 13 '22 22:09 taeold

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: KexZc1Ygnm1Oyjv7jY5k

taeold avatar Sep 13 '22 23:09 taeold