firebase-tools icon indicating copy to clipboard operation
firebase-tools copied to clipboard

Fix uploads from android sdk to the storage emulator

Open Yuangwang opened this issue 3 years ago • 1 comments

Description

Fixes issue where blocked uploads from the android sdk crash the storage emulator

Scenarios Tested

Tested manually from the android sdks and modified integration tests to accommodate the new flow.

Yuangwang avatar Aug 11 '22 15:08 Yuangwang

Codecov Report

Merging #4860 (64075c9) into master (3c35d8f) will decrease coverage by 0.02%. The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master    #4860      +/-   ##
==========================================
- Coverage   56.73%   56.71%   -0.03%     
==========================================
  Files         288      288              
  Lines       19110    19124      +14     
  Branches     3792     3796       +4     
==========================================
+ Hits        10843    10846       +3     
- Misses       7349     7360      +11     
  Partials      918      918              
Impacted Files Coverage Δ
src/emulator/storage/apis/firebase.ts 3.95% <12.50%> (-0.11%) :arrow_down:
src/emulator/storage/upload.ts 66.12% <14.28%> (-6.60%) :arrow_down:
src/emulator/auth/state.ts 85.35% <0.00%> (+0.56%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 11 '22 15:08 codecov-commenter